[SHACK-304] Updating dependencies to fix ChefDK build pipeline failures #33
Conversation
There was a problem hiding this comment.
All the google-* deps will be removed soon via inspec/train#329
I am interpreting this as:
Yes, this is a lot of new dependencies. Don't worry about the Google ones; they won't be staying long.
Is that right?
| aws-sdk (~> 2) | ||
| azure_mgmt_resources (~> 0.15) | ||
| docker-api (~> 1.26) | ||
| google-api-client (~> 0.19.8) |
There was a problem hiding this comment.
I am cautiously optimistic that this will still allow kitchen-google—which also requires google-api-client—to get chef gem install'd into a Workstation.
chef-apply.gemspec
Outdated
| @@ -48,7 +48,7 @@ Gem::Specification.new do |spec| | |||
| # localization gem... | |||
| spec.add_dependency "toml-rb" # This isn't ideal because mixlib-config uses 'tomlrb' | |||
| # but that library does not support a dumper | |||
| spec.add_dependency "train" # remote connection management over ssh, winrm | |||
| spec.add_dependency "train", ">= 1.4.24" # remote connection management over ssh, winrm | |||
There was a problem hiding this comment.
Are there any notes we can add to the commit message about why this minimum version?
There was a problem hiding this comment.
I'm actually just going to get rid of this constraint. I did it to force us to use the same version the ChefDK does but that will get reconciled automatically when the ChefDK solves its entire dependency universe
|
@robbkidd That is correct - the google dependencies will not be staying long |
All the google-* deps will be removed soon via inspec/train#329 I got rid of the 'localdev' group because having those gems in the lock was causing issues with running the ChefDK tests. We can add them back later if we want. Signed-off-by: tyler-ball <tball@chef.io>
tyler-ball
force-pushed
the
SHACK-304/deps
branch
from
f30b824 to
f9ca8b5
Compare
Description
All the google-* deps will be removed soon via inspec/train#329
I got rid of the 'localdev' group because having those gems in the lock
was causing issues with running the ChefDK tests. We can add them back
later if we want.
Issues Resolved
SHACK-304
Check List
Signed-off-by: tyler-ball tball@chef.io